feat: MaveMD score set landing table redesign - #719
Open
bencap wants to merge 2 commits into
Open
Conversation
Add getPublicationUrl to src/lib/publication (url -> DOI -> PubMed fallback) and use it in MvPublicationsSection and PublicationIdentifierView, which previously linked out only when the identifier carried a resolved url. Both now fall back to a doi.org or pubmed.ncbi.nlm.nih.gov link. Add unit tests for the helper.
Rework the MaveMD score set table for a collection that has grown past 80 datasets, per #694. - Add a gene typeahead filter, inlined with the section heading, that searches the whole collection rather than just the 8-gene preview. - Merge the Score set and Publication columns into one: the title links to the score set and the citation links out to the publication. This fixes the old Publication link, which pointed back at the score set page instead of the article. - Replace the opaque "X / Y" calibration badge with a labeled status: None, Uncalibrated, Research use only, or Calibrated. A score set counts as Calibrated once one non-RUO calibration assigns ACMG evidence; RUO-only evidence is flagged rather than shown as clinical. - Add a Variants column showing the variant count. - Enlarge and pad the rows and add each score set's short description. - Explain the calibration states in a bulleted header tooltip. Score-set publication links resolve through the shared getPublicationUrl helper. Add unit tests for the score-set helper.
10 tasks
|
coverage: 10.822% (+0.5%) from 10.274% — feature/bencap/694/mavemd-landing-scoreset-table into release-2026.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesigns the MaveMD landing-page score set table (
SearchVariantsScreen.vue). Implements the four improvements in #694, plus a density/readability pass. No backend changes — all data is already on theScoreSetobjects.What changed
X / Ybadge is replaced with a labeled status — None, Uncalibrated, Research use only, or Calibrated — linking to the calibrations page, with a bulleted tooltip on the column header explaining each state.numVariantswith a thousands separator.Calibration status semantics
A score set is
Calibratedas soon as one non-RUO calibration assigns ACMG/AMP evidence strengths — it does not require every calibration to carry evidence. The one caveat is research-use-only: when the only evidence-bearing calibrations are RUO, the badge readsResearch use onlyrather thanCalibrated.Refactor (first commit)
Publication-URL resolution is extracted into
src/lib/publication(getPublicationUrl:url→ DOI → PubMed) and adopted inMvPublicationsSectionandPublicationIdentifierView, which previously linked out only when the identifier carried a resolvedurl. Both now get the DOI / PubMed fallback.Screenshots
Before:
After:
